From: Junio C Hamano Date: Wed, 21 Jun 2017 21:52:31 GMT Subject: Re: [PATCH 04/26] diff.c: introduce emit_diff_symbol Message-ID: In-Reply-To: <20170621214551.GE53348@google.com> Brandon Williams writes: > I don't think this is strictly enforced. If you look at grep.h:197 the > enum 'grep_source_type' has a trailing comma. OK, so we now know that at least since e1327023 ("grep: refactor the concept of "grep source" into an object", 2012-02-02) we haven't heard from anybody whose compiler fails to grok this. Perhaps we should start pushing for C99 features?