From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 09 Aug 2017 15:50:06 GMT
Subject: Re: [PATCH 2/2] filter-branch: Handle rewritting (very) old style tags which lack tagger
Message-ID: <xmqqlgms7nbl.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170809102040.l5sb6ukqh2225zqm@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Tue, Aug 08, 2017 at 09:06:20AM +0100, Ian Campbell wrote:
>
>> Such as v2.6.12-rc2..v2.6.13-rc3 in the Linux kernel source tree.
>> 
>> Insert a fake tag header, since newer `git mktag` wont accept the input
>> otherwise:
>
> Hmm. Now your resulting tag will have this crufty "unknown@example.com"
> header baked into it, won't it?
>
> Should we instead make git-mktag more lenient (possibly with a
> command-line option to reduce accidental omissions)?

That sounds sensible. Thanks for injecting a dose of sanity.