From: Junio C Hamano Date: Sun, 24 Sep 2017 06:56:04 GMT Subject: Re: [PATCH v2 13/21] packed_ref_cache: keep the `packed-refs` file mmapped if possible Message-ID: In-Reply-To: <354c8088-ae24-479d-3b4e-fe8e189223b2@alum.mit.edu> Michael Haggerty writes: >> + struct stat st; >> + size_t size, bytes_read; > > Coverity helpfully pointed out that `bytes_read` has to be signed: > `ssize_t`. I'll fix that in the next round after waiting for other comments. Thanks. The macOS build at Travis also was also upset about it, so I'd tentatively queue a trivial squash on top.