From: Junio C Hamano Date: Mon, 04 Dec 2017 13:45:33 GMT Subject: Re: [PATCH] send-email: extract email-parsing code into a subroutine Message-ID: In-Reply-To: Nathan PAYRE writes: > I've tested your code, and after few changes it's works perfectly! > The code looks better now. > Thanks a lot for your review. Thanks, both of you. Could you send in the final version later so that I can pick it up? I agree with Matthieu's suggestion on what address to use on your From: (authorship identity) and S-o-b:; as you are showing your work done as a uni student, the authorship and sign-off should be done as such.