From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 11 Jan 2018 20:37:05 GMT
Subject: Re: [PATCH v2 0/2] Incremental rewrite of git-submodules
Message-ID: <xmqqlgh4xhce.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20180111201721.25930-1-pc44800@gmail.com>

Prathamesh Chavan <pc44800@gmail.com> writes:

> Changes made to the previous version of the patch series[1]:
>
> * Since later on with certain patches, the number of bit-parameters to
>   be passed to a few functions depend on many parameters, I prefered
>   using a single flag bit.

I am not quite getting what you meant to say here.

> * Memory-leak of the variable 'remote' in the function:
>   print_default_remote() was avoided.

avoided how?  I am not quite getting what you meant to say here.

> * Additional condition were introduced while freeing the variables:
>   sub_origin_url and super_config_url.

As I said, I do not think the change goes into the right direction.