From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 14 Jan 2019 22:11:26 GMT
Subject: Re: [PATCH 2/4] sideband: reverse its dependency on pkt-line
Message-ID: <xmqqlg3mubxt.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <xmqq4labuho5.fsf@gitster-ct.c.googlers.com>

Junio C Hamano <gitster@pobox.com> writes:

> Lack of corresponding comment bothers readers.  In all of
> REMOTE_ERROR, PROGRESS and PROTOCOL_ERROR cases, the other helper
> stuffs the message in outbuf in "switch (band) { ... }" and writes
> it out with xwrite(2, outbuf.buf, outbuf.len) [*1*], so I can see
> there is no need for us to write anything out here.  Perhaps
>
> 		case SIDEBAND_FLUSH:
> 		default: /* errors: message already written */
> 			return retval;
>
> or something to clarify?

Forgot a footnote for *1* above.  I was wondering if xwrite is what
we really want, rather than write_in_full().