From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 07 Jan 2020 20:21:05 GMT
Subject: Re: [PATCH 1/3] graph: fix case that hit assert()
Message-ID: <xmqqlfqj3tn2.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20200107193143.GA56858@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Tue, Jan 07, 2020 at 11:21:00AM -0800, Junio C Hamano wrote:
>
>> Jeff King <peff@peff.net> writes:
>> 
>> >> Second, the horizontal lines in that first line drop their coloring.
>> >> This is due to a use of graph_line_addch() instead of
>> >> graph_line_write_column(). Using a ternary operator to pick the
>> >> character is nice for compact code, but we actually need a column
>> >> to provide the color.
>> >
>> > It seems like this is a totally separate bug, and could be its own
>> > commit?
>> 
>> I think so.
>> 
>> And with that removed, all that remains would be a removal of the
>> assert() plus an additional test?
>
> Yes, though note that the color thing is a v2.25 regression as well. So
> we'd probably want both of them.

Sure.  Those two would make perfect pair of commits to finish -rc2 with.

Thanks.