From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 25 Feb 2020 17:48:02 GMT
Subject: Re: [PATCH v5 3/3] tag: use new advice API to check visibility
Message-ID: <xmqqlfoqmuct.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <01b195ebe1d2ab1593915318b7e8adbee5d9614c.1582628141.git.gitgitgadget@gmail.com>

"Heba Waly via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Heba Waly <heba.waly@gmail.com>
>
> Following the new helpers added to the advice library,
> replace the global variable check approach by the new
> API calls

The last paragraph of the proposed log message you had for [2/3]
described that this step is just an example better than the above
one, which would leave readers puzzled what our plans are for dozens
of existing advise() calls.

> +	if (type == OBJ_TAG)
> +		advise_if_enabled(NESTED_TAG, _(message_advice_nested_tag),
> +				  tag, object_ref);

This is probably a good enough example why OBJ_TAG is a good name
but NESTED_TAG is not---type could be something different from
OBJ_TAG but the other possiblities are all OBJ_<object-type>.  We
want the advice types to have the same property.