From: Junio C Hamano Date: Mon, 28 Sep 2020 22:37:00 GMT Subject: Re: git commit-tree does not honor commit.gpgSign config Message-ID: In-Reply-To: Evan Grim writes: > On Mon, Sep 28, 2020 at 12:46 PM Junio C Hamano wrote: >> >> Evan Grim writes: >> >> > Is it a bug that `git-commit-tree` doesn't honor the `commit.gpgSign` >> > configuration option? >> >> It would be a bug if it did, as a low level plumbing tool to build >> scripts around, it would not want its behaviour to be affected by >> end-user configuration (rather, scripts that are written using these >> plumbing command do want to handle end-user customization their own >> ways). > > Thank you for that context. I came across this when I used > `git-subtree` and was surprised the commits it created weren't signed. > Would it be appropriate to look into patching `git-subtree` to honor > the configuration option? Yes, the script that invokes "commit-tree" is at the right layer to notice commit.gpgsign and possibly $name_of_the_script.gpgsign configuration variable(s) and add the -S option, I would think. I do not know if there are people who are still using, or who is maintaining, the "subtree" script, though. Thanks.