From: Junio C Hamano Date: Tue, 20 Oct 2020 03:10:56 GMT Subject: Re: [PATCH v3 5/7] perf lint: check test-lint-shell-syntax in perf tests Message-ID: In-Reply-To: <20201020023857.GC54484@nand.local> Taylor Blau writes: >> echo change$i >unrelated-file$i && >> - seq 1000 | tac >>unrelated-file$i && >> + test_seq 1000 | tac >>unrelated-file$i && > > Makes sense. I wouldn't be opposed to breaking this out into an earlier > change (e.g., "it's about to become not OK to use seq in t/perf, so > prepare for that by replacing any invocations with test_seq()"), but I > think it's probably not worth it, since this patch is small as it is. test_seq is fine, but I do not think tac is portable (only saved by the fact that not many people, especially on exotic platforms, run perf scripts).