From: Junio C Hamano Date: Tue, 26 Jan 2021 02:25:29 GMT Subject: Re: [PATCH v2] upload-pack.c: fix filter spec quoting bug Message-ID: In-Reply-To: Jeff King writes: > On Mon, Jan 25, 2021 at 11:48:07AM -0800, Junio C Hamano wrote: > >> I suspect that 0b6069fe (fetch-pack: test support excluding large >> blobs, 2017-12-08) sort-of fixed half of the problem (i.e. the half >> when there is no hook used) while leaving the other half still >> broken as before. >> >> But because .use_shell does not affect if we should or should not >> quote, we can unconditionally drop the use of sq_quote_buf(). > > Yep. That was the same conclusion I came to in my earlier reply: > > https://lore.kernel.org/git/YAs2RMT1rEH%2F2LSp@coredump.intra.peff.net/ Thanks. As I am behind, I needed to think it aloud to make sure I am on the same page as others ;-) A sanity check like this is greatly appreciated.