From: Junio C Hamano Date: Tue, 16 Feb 2021 23:03:46 GMT Subject: Re: [OUTREACHY][PATCH v1] doc: fix naming of response-end-pkt Message-ID: In-Reply-To: <5qGT6uzPLUGN2DXCMTzhixEhKHwaT6hODaOHQ485sfCROycrTDPx6P2Nd5dOy4J-gnhb_lKpxW4jJqhut-4gmoeIyuhpqbA5fXCeHoKHrK8=@protonmail.com> Joey Salazar writes: > Git Protocol version 2[1] defines 0002 as a Message Packet that indicates > the end of a response for stateless connections. > > Change the naming of the 0002 Packet to 'Response end' to match the > parsing introduced in Wireshark's MR !1922 for consistency. > > [1] kernel.org/pub/software/scm/git/docs/technical/protocol-v2.html > [2] gitlab.com/wireshark/wireshark/-/merge_requests/1922 > > Signed-off-by: Joey Salazar > --- > Documentation/technical/protocol-v2.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) This came from b0df0c16 (stateless-connect: send response end packet, 2020-05-19), didn't it? The original commit even says "response end packet" on its title, so I am reasonably sure the patch under discussion is an improvement ;-) Having said that, asking its author to review the change would be the most appropriate (cc'ed). Thanks. > > diff --git a/Documentation/technical/protocol-v2.txt b/Documentation/technical/protocol-v2.txt > index e597b74da39..6c55d566d8b 100644 > --- a/Documentation/technical/protocol-v2.txt > +++ b/Documentation/technical/protocol-v2.txt > @@ -33,8 +33,8 @@ In protocol v2 these special packets will have the following semantics: > > * '0000' Flush Packet (flush-pkt) - indicates the end of a message > * '0001' Delimiter Packet (delim-pkt) - separates sections of a message > - * '0002' Message Packet (response-end-pkt) - indicates the end of a response > - for stateless connections > + * '0002' Response end Packet (response_end-pkt) - indicates the end of a > + response for stateless connections > > Initial Client Request > ---------------------- > -- > 2.29.0.rc2