From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 15 Apr 2021 20:32:14 GMT
Subject: Re: [PATCH] pkt-line: do not report packet write errors twice
Message-ID: <xmqqlf9jp9v5.fsf@gitster.g>
In-Reply-To: <CAHd-oW4sqJpeJywgRJCkchX0uZFSxD-UnguRJcRcQQywd+scbA@mail.gmail.com>

Matheus Tavares Bernardino <matheus.bernardino@usp.br> writes:

> Nice! :) Maybe we could also avoid the static strings without
> repeating the literals by making `do_packet_write()` receive a `struct
> strbuf *err` and save the error message in it? Then the two callers
> can decide whether to pass it to error() or die() accordingly.

Sorry, but I do not understand what benefit we are trying to gain by
introducing an extra strbuf (which I assume is used to strbuf_add()
the error message into).  Wouldn't the caller need two messages and
flip between <error,error_errno> vs <die,die_errno> pair?