From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 29 Jul 2021 00:58:55 GMT
Subject: Re: [PATCH v6 1/9] ssh signing: preliminary refactoring and clean-up
Message-ID: <xmqqlf5q6ils.fsf@gitster.g>
In-Reply-To: <20210728223206.2715554-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

>> -	fmt = get_format_by_sig(signature);
>> -	if (!fmt)
>> -		BUG("bad signature '%s'", signature);
>
> Here is the difference in functionality that I spotted. Here, lack of
> fmt is fatal...
>
>> +	fmt = get_format_by_sig(signature);
>> +	if (!fmt)
>> +		return error(_("bad/incompatible signature '%s'"), signature);
>
> ...but here it is not.

While I was reviewing this step, I was assumign that the callers
would respond to this error return appropriately.  If it is not the
case, then we do have to fix that.

The original's use of BUG() is wrong in any case, I woud think.  The
"signature" there is an external input, so we were reporting a data
error (it should have been die()), not a program logic error.

Thanks.