From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 10 Aug 2021 21:38:26 GMT
Subject: Re: [PATCH 3/7] grep: typesafe versions of grep_source_init
Message-ID: <xmqqlf59c759.fsf@gitster.g>
In-Reply-To: <e5e6a0dc1ef59b2ab419816e463814d93115e7f6.1628618950.git.jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

> grep_source_init() can create "struct grep_source" objects and,
> depending on the value of the type passed, some void-pointer parameters have
> different meanings. Because one of these types (GREP_SOURCE_OID) will
> require an additional parameter in a subsequent patch, take the
> opportunity to increase clarity and type safety by replacing this
> function with individual functions for each type.

Nice clean-up.