From: Junio C Hamano Date: Mon, 16 Jan 2023 18:39:18 GMT Subject: Re: [PATCH v2 0/6] cache API: always have a "istate->repo" Message-ID: In-Reply-To: Philip Oakley writes: > On 16/01/2023 13:38, Ævar Arnfjörð Bjarmason wrote: >> On Fri, Jan 13 2023, Junio C Hamano wrote: >> >>> Ævar Arnfjörð Bjarmason writes: >>> >>>> The "struct index_state" contains a "repo" member, which should be a >>>> pointer to the repository for that index, but which due to us >>>> constructing such structs on an ad-hoc basis in various places wasn't >>>> always available. >>> I'd exclude 6/6 for now, as it seems to depend on some changes only >>> in 'next'. Feel free to resend only that step with reduced scope so >>> that it applies to 'master', and send in incremental updates when >>> each of these topics that are only in 'next' graduates. >> Okey, the 6/6 requires ds/omit-trailing-hash-in-index. As both it and >> the 1-5/6 of this are in "next" now I think it's best that I just submit >> the 6/6 stand-alone after both of those have graduated. >> > micro-nit: The commit message of 5/6 starts "As we'll see in a > subsequent commit..", which may need a slight tweak if 6/6 becomes 'far > away' in the commit tree. Indeed. I'd use Hopefully in some not so distant future, we'll get advantages from always initializing the "repo" member ... for now.