From: Junio C Hamano Date: Sat, 09 Mar 2024 05:53:17 GMT Subject: Re: [PATCH 2/2] setup: make bareRepository=explicit work in GIT_DIR of a secondary worktree Message-ID: In-Reply-To: <87msr8qef9.fsf@kyleam.com> Kyle Meyer writes: >> Now, for the same reason, let's allow command execution from within >> the $GIT_DIR directory of a secondary worktree. This is useful for >> tools working with secondary worktrees when the 'bareRepository' >> setting is set to 'explicit'. > > Does the same reason also apply to .git/modules/$name ? Perhaps. I do not actively work on submodules so unlike those who are always thinking about improving the user experience around them, I did not think of those ".git/modules/$name" things as something similar to the ".git/worktrees/$name" things. Often hooks (and probably third-party tools) run after chdir to be in $GIT_DIR, so the problems they face when their /etc/gitconfig forces them to use safe.bareRepository=explicit are probably very similar either way.