From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 26 Jan 2026 19:12:18 GMT
Subject: Re: [PATCH 1/2] u-string-list: add unit tests for string-list methods
Message-ID: <xmqqldhki3xp.fsf@gitster.g>
In-Reply-To: <CAPvEtrcLrrRhOi2OCaQzD6xNSHbyv38cr5-WLRPg_HGW5UKzAg@mail.gmail.com>

Amisha Chhajed <amishhhaaaa@gmail.com> writes:

>> > +     for (int i = 0; i < strings_to_insert.nr; i++) {
>>
>> As strings_to_insert.nr is of type size_t, even though int is plenty
>> large enough in practice, the compiler will complain.
>>
>> > +             string_list_insert(&list, strings_to_insert.items[i].string);
>> > +     }
>>
>> Also, lose the {} around a single statement block.
>
> Done, Thanks for the review.

Heh, that wasn't even a review but a knee-jerk reaction to compiler
warnings.