From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 22 Jun 2026 12:57:03 GMT
Subject: Re: [PATCH v3] config.mak.uname: avoid macOS dup-library warning
Message-ID: <xmqqldc63f8g.fsf@gitster.g>
In-Reply-To: <ajjspU7lJ01GgrBw@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

>> Yeah, this looks like what I expected.
>> 
>> A few things to note.
>> 
>>  * Can folks with different versions of Xcode (or is 15 sufficiently
>>    old that practically nobody is expected to have anything older?)
>>    test this patch?
>> 
>>  * We only patch Makefile here; can folks who use meson report how
>>    well your build goes?
>
> When using Meson we also see a warning. This got partially fixed in
> Meson itself though via [1], where it started to disable the warning
> when compiling with "--fatal-warnings" so that it doesn't cause builds
> to break. So starting with that commit it really only is a harmless
> (albeit annoying) warning.
>
> Arguably, it might make sense to unconditionally disable this warning,
> as it doesn't seem to add anything of value. I've Cc'd Paolo, one of the
> Meson maintainers.
>
> Thanks!
>
> Patrick
>
> [1]: https://github.com/mesonbuild/meson/commit/17d1cc60ed8246b8e7f0786421bf1cdf5cb19254

I took my inspiration for -Wl,-no-whatever from Paolo's other
attempt, referenced in

    https://github.com/mesonbuild/meson/issues/15553

which is

    https://github.com/mesonbuild/meson/commit/7c901d7a8af214e31788eb6d1a1edd5b75124e66