From: Junio C Hamano Date: Tue, 14 Jul 2026 15:34:26 GMT Subject: Re: [PATCH v4 2/2] fetch: add fetch.submoduleErrors to make submodule fetch errors non-fatal Message-ID: In-Reply-To: <20260714132959.3368867-3-paulius.zaleckas@gmail.com> Paulius Zaleckas writes: > t/t5526-fetch-submodules.sh | 89 ++++++++++++++++++++++++++++++++ > 6 files changed, 168 insertions(+), 4 deletions(-) In addition to what was pointed out by Ramsay in his squashable patch <387a34d5-fdf5-4513-9aaf-4e73d9304c1d@ramsayjones.plus.com> this round adds another use of raw grep that is caught by the test framework. commit 8f7761ee72b3669c1aee98142852437d016c785c Author: Junio C Hamano Date: Tue Jul 14 08:31:57 2026 -0700 fixup! fetch: add fetch.submoduleErrors to make submodule fetch errors non-fatal diff --git a/t/t5526-fetch-submodules.sh b/t/t5526-fetch-submodules.sh index 614d45ab71..19d17440cf 100755 --- a/t/t5526-fetch-submodules.sh +++ b/t/t5526-fetch-submodules.sh @@ -1408,7 +1408,7 @@ test_expect_success '--submodule-errors=fail overrides warn config for fetch --a git -C env_override/clone config fetch.submoduleErrors warn && test_must_fail git -C env_override/clone fetch --all --recurse-submodules \ --submodule-errors=fail 2>err && - grep "Errors during submodule fetch" err + test_grep "Errors during submodule fetch" err ' test_expect_success 'fetch.submoduleErrors=warn: inaccessible submodule is non-fatal' '