From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 20 Jun 2014 17:31:08 GMT
Subject: Re: [PATCH v2 02/14] submodules: Add the lib-submodule-update.sh test library
Message-ID: <xmqqk3847k4r.fsf@gitster.dls.corp.google.com>
In-Reply-To: <53A3443D.9020000@web.de>

Jens Lehmann <Jens.Lehmann@web.de> writes:

> +		rm -rf sub1 &&
> +		git checkout -f "$1" &&
> +		git status -u -s >actual &&
> +		test_must_be_empty actual &&
> +		sha1=$(git rev-parse HEAD:sub1 || true) &&

	$ xx=; xx=$(git rev-parse HEAD:no-such-path || true) ; echo $? ; echo "<$xx>"
        fatal: Path 'no-such-path' does not exist in 'HEAD'
        0
        <HEAD:no-such-path>

Perhaps you want --verify (or --revs-only) there, i.e.

	sha1=$(git rev-parse --verify HEAD:sub1 || :) &&

or

	sha1=$(git rev-parse --revs-only HEAD:sub1) &&

> +		if test -n "$sha1" &&
> ...
> +	sha1=$(git rev-parse "$commit:$submodule") &&

And here too.

> +	if test -z "$sha1"