From: Junio C Hamano Date: Mon, 21 Sep 2015 22:41:34 GMT Subject: Re: [PATCH v2] format-patch: introduce format.outputDirectory configuration Message-ID: In-Reply-To: Eric Sunshine writes: > On Fri, Jun 19, 2015 at 2:28 PM, Alexander Kuleshov > wrote: >> We can pass -o/--output-directory to the format-patch command to >> store patches not in the working directory. This patch introduces >> format.outputDirectory configuration option for same purpose. >> >> The case of usage of this configuration option can be convinience > > s/convinience/convenience/ > >> to not pass everytime -o/--output-directory if an user has pattern > > s/everytime/every time/ > >> to store all patches in the /patches directory for example. >> >> The format.outputDirectory has lower priority than command line >> option, so if user will set format.outputDirectory and pass the >> command line option, a result will be stored in a directory that >> passed to command line option. >> >> Signed-off-by: Alexander Kuleshov >> --- Looks like there were mostly editorial niggles and no fundamental flaws in the design of the patch; it is somewhat a shame to make all the efforts go to waste. Will we be seeing an update soon? We are deep in the pre-release feature freeze, so unless you are participating in regression fixes it is a good time to plan for the next cycle. Thanks. >> +static const char *config_output_directory = NULL; s/ = NULL;/;/ (do rely on BSS clearing the static variables).