From: Junio C Hamano Date: Tue, 27 Oct 2015 20:59:49 GMT Subject: Re: [PATCH 5/9] submodule update: expose parallelism to the user Message-ID: In-Reply-To: <1445969753-418-6-git-send-email-sbeller@google.com> Stefan Beller writes: > @@ -374,6 +374,10 @@ for linkgit:git-clone[1]'s `--reference` and `--shared` options carefully. > clone with a history truncated to the specified number of revisions. > See linkgit:git-clone[1] > > +-j:: > +--jobs:: This probably should be -j :: --jobs :: (see comments on [6/9]). I know the option description in this file is sloppy and does not say "--name " etc., as it should (but it does say "--reference "), and fixing them may not be within the scope of this series, but we do not need to add more to the existing problems. > + This option is only valid for the update command. > + Clone new submodules in parallel with as many jobs. And when 0 starts to meaning something special, we would need to describe that here (and/or submodule.jobs entry in config.txt). As I already said, I do not think "0 means num_cpus" is a useful default, and I would prefer if we reserved 0 to mean something more useful we would figure out later. Thanks.