From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 28 Oct 2015 17:12:00 GMT
Subject: Re: [PATCH v4 0/2] Fix interactive rebase when the editor saves with CR/LF
Message-ID: <xmqqk2q6lxy7.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <cover.1446043983.git.johannes.schindelin@gmx.de>

Johannes Schindelin <johannes.schindelin@gmx.de> writes:

> Turns out that we now check whether a single Carriage Return is a valid
> command. This new check was introduced recently (1db168ee9, ironically
> named "rebase-i: loosen over-eager check_bad_cmd check").

Will queue.

The root cause is not really "a new check added recently".  Earlier
the edited result was fed to stripspace and because "stripspace"
does what a dos-to-unix filter that turns CRLF into LF in addition
to cleaning up spaces and comments, we did not see the problematic
behaviour from "read" in this codepath.

Thanks.