From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 17 Jun 2016 17:29:26 GMT
Subject: Re: [PATCH 2/4] add smudge-to-file and clean-from-file filter configuration
Message-ID: <xmqqk2hn207d.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqq60t73igm.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

> I wonder if we prefer not to make this customizable (i.e. not having
> to use'%p').  Unlike '%f' that is optional, smudgeTo and cleanFrom
> "filters" are not filters and MUST read from the path given and not
> from any other paths.
> ...
> Would an interface that always appends the pathname at the end of
> the command line string work?

Just to avoid misunderstanding, when I say "I wonder if we want to
go this route instead", I am open to a response that says "No, we do
not; going that route is worse because ...".  Please do not take it
as a suggestion or request to "do it this way instead".

I may not even favor that other "route" I mention in my message with
"I wonder"; I am merely saying that I cannot come up with that
"because ..."  part to reject it myself, and asking for help from
others.

In this case, I would be happy to hear "Yes, '%p' may merely be a
way to allow taking the pathname at anywhere on the command line,
but that flexibility is important because...".

Thanks.