From: Junio C Hamano Date: Thu, 14 Jul 2016 20:07:51 GMT Subject: Re: [PATCH 2/4] receive-pack: implement advertising and receiving push options Message-ID: In-Reply-To: <20160714194522.GA17798@sigill.intra.peff.net> Jeff King writes: > packet_read() does NUL-terminate for you. It gets the extra bytes > because it doesn't store the 4-byte size in the output (whereas the > client does not ever send anything over LARGE_PACKET_MAX, _including_ > those bytes, so we always have room to store its result in our > LARGE_PACKET_MAX buffer, plus the NUL, with 3 bytes to spare). Good; then the loop will further be simplified ;-) Thanks.