From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 15 Jul 2016 18:00:52 GMT
Subject: Re: [PATCH 02/12] rev-list: add optional progress reporting
Message-ID: <xmqqk2gmn5m3.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160715102806.GB19271@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> diff --git a/builtin/rev-list.c b/builtin/rev-list.c
> index b82bcc3..88d95a7 100644
> --- a/builtin/rev-list.c
> +++ b/builtin/rev-list.c
> @@ -9,6 +9,7 @@
>  #include "log-tree.h"
>  #include "graph.h"
>  #include "bisect.h"
> +#include "progress.h"
>  
>  static const char rev_list_usage[] =
>  "git rev-list [OPTION] <commit-id>... [ -- paths... ]\n"
> @@ -49,12 +50,17 @@ static const char rev_list_usage[] =
>  "    --bisect-all"
>  ;
>  
> +struct progress *progress;
> +unsigned progress_counter;

Are these supposed to be file-scope static?