From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 15 Sep 2016 19:15:50 GMT
Subject: Re: [PATCH v2 10/25] sequencer: get rid of the subcommand field
Message-ID: <xmqqk2ednfdl.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <955727a7cf5bd64f1c1106b394095d5449a4a2dc.1473590966.git.johannes.schindelin@gmx.de>

Johannes Schindelin <johannes.schindelin@gmx.de> writes:

> The subcommands are used exactly once, at the very beginning of
> sequencer_pick_revisions(), to determine what to do. This is an
> unnecessary level of indirection: we can simply call the correct
> function to begin with. So let's do that.

Makes sense.  And the diffstat is also pleasant to the eyes.

>  builtin/revert.c | 36 ++++++++++++++++--------------------
>  sequencer.c      | 35 +++++++++++------------------------
>  sequencer.h      | 13 ++++---------
>  3 files changed, 31 insertions(+), 53 deletions(-)