From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 13 Feb 2017 20:38:47 GMT
Subject: Re: [PATCH] clean: use warning_errno() when appropriate
Message-ID: <xmqqk28tddwo.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170213191433.muwhz7zem64p3rxr@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I wonder if xmalloc() should be the one doing the saved_errno trick.
> After all, it has only two outcomes: we successfully allocated the
> memory, or we called die().

I would be lying if I said I did not considered it when I wrote the
message you are responding to, but I rejected it because that would
be optimizing for a wrong case, in that most callers of xmalloc()
and friends do not do so in the error codepath, and we would be
penalizing them by doing the saved_errno dance unconditionally.