From: Junio C Hamano Date: Wed, 01 Mar 2017 17:52:12 GMT Subject: Re: [PATCH v7 0/3] Conditional config include Message-ID: In-Reply-To: <20170301112631.16497-1-pclouds@gmail.com> Nguyễn Thái Ngọc Duy writes: > Nguyễn Thái Ngọc Duy (3): > config.txt: clarify multiple key values in include.path > config.txt: reflow the second include.path paragraph > config: add conditional include Thanks. The primary change looked good (it looked good already in the previous round). Here is a list of minor suggestions on top. diff --git a/Documentation/config.txt b/Documentation/config.txt index 2a41e84bab..5faabc7934 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -82,7 +82,7 @@ Includes You can include a config file from another by setting the special `include.path` variable to the name of the file to be included. The variable takes a pathname as its value, and is subject to tilde -expansion. `include.path` supports multiple key values. +expansion. `include.path` can be given multiple times. The included file is expanded immediately, as if its contents had been found at the location of the include directive. If the value of the @@ -96,8 +96,7 @@ Conditional includes You can include a config file from another conditionally by setting a `includeIf..path` variable to the name of the file to be included. The variable's value is treated the same way as -`include.path`. `includeIf.path` supports multiple key -values. +`include.path`. `includeIf..path` can be given multiple times. The condition starts with a keyword followed by a colon and some data whose format and meaning depends on the keyword. Supported keywords