From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 22 Mar 2017 21:29:57 GMT
Subject: Re: [PATCH 0/6] thread lazy_init_name_hash
Message-ID: <xmqqk27hhuei.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1a23fa5d-3b80-ca47-fcaa-56f794699aab@jeffhostetler.com>

Jeff Hostetler <git@jeffhostetler.com> writes:

> On 3/22/2017 4:54 PM, Junio C Hamano wrote:
>>>
>>> Thank you for an update.
>>
>> One notable difference I noticed since the previous round is that
>> this no longer adds precomputed hash to "struct cache_entry".  As
>> you are aiming to manage an index with a large number of entries,
>> this is a welcome change that makes sense.
>
> Yes, this completely isolates the changes inside the name-hash.c
> code.  And it eliminates the need to update/invalidate the precomputed
> hash values as entries are changed.

Thanks.  Having a summary like that for differences since the last
round in the cover letter would help during the review, but this is
an example that lack of such a summary would be one way to make sure
that reviewer(s) are paying attention ;-)