From: Junio C Hamano Date: Tue, 18 Apr 2017 02:03:04 GMT Subject: Re: [PATCH v2 2/2] ls-files: fix path used when recursing into submodules Message-ID: In-Reply-To: <20170413171224.3537-2-jacob.e.keller@intel.com> Jacob Keller writes: > From: Jacob Keller > > Don't assume that the current working directory is the root of the > repository. Correctly generate the path for the recursing child > processes by building it from the work_tree() root instead. Otherwise if > we run ls-files using --git-dir or --work-tree it will not work > correctly as it attempts to change directory into a potentially invalid > location. Best case, it doesn't exist and we produce an error. Worst > case we cd into the wrong location and unknown behavior occurs. > > Add a new test which highlights this possibility. > > Signed-off-by: Jacob Keller > --- > I'm not sure that I'm convinced by this method of solving the problem as > I suspect it has some corner cases (what about when run inside a > subdirectory? It seems to work for me but I'm not sure...) Additionally, > it felt weird that there's no helper function for creating a toplevel > relative path. Is this a similar issue as discussed in a nearby thread e.g. I do think it is a bug that sometimes we do not go to the root of the working tree when we know the repository is not a bare one.