From: Junio C Hamano Date: Wed, 17 May 2017 07:09:45 GMT Subject: Re: [PATCH] sha1dc: fix issues with a big endian platform Message-ID: In-Reply-To: Ævar Arnfjörð Bjarmason writes: > On Wed, May 17, 2017 at 7:39 AM, Junio C Hamano wrote: >> From: Marc Stevens >> >> Some big-endian platforms define _BIG_ENDIAN, which the test at the >> beginning of file has missed. Also, when the input is not aligned, >> some platforms trigger SIGBUS. >> >> This change corresponds to 33a694a9 ("Fix issues with a big endian >> platform", 2017-05-15) in the history of the upstream repository >> https://github.com/cr-marcstevens/sha1collisiondetection > > Then why not just update sha1dc from upstream instead of > cherry-picking one patch from them? See the original message upthread. I did the cherry-pick simply because that was what Marc instructed the patch recipient to do ;-).