From: Junio C Hamano Date: Thu, 25 May 2017 05:25:50 GMT Subject: Re: [PATCH 24/29] blame: move core structures to header Message-ID: In-Reply-To: <20170524051537.29978-25-whydoubt@gmail.com> Jeff Smith writes: > The origin, entry, and scoreboard structures are core to the blame > interface and need to be exposed for blame functionality. > > Signed-off-by: Jeff Smith > --- Looks good. Thanks to "prepare everything in place before bulk movement" approach this round takes, unlike the previous one, reviewing this is just the matter of running $ git blame -C -b HEAD^..HEAD -- blame.h after applying this patch. Anything that is shown as "introduced" by HEAD needs careful examination; everything else we already know are good because we know it came from existing parts. Thanks.