From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 30 May 2017 23:17:14 GMT
Subject: Re: [PATCH v3 13/13] is_missing_file_error(): work around EINVAL on Windows
Message-ID: <xmqqk24y9bph.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kZC4WM=aXPO9Rk1GQ7+XKUhoWUZefjM6Trk-11QcrhBYA@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

> On Thu, May 25, 2017 at 8:35 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> When asked to open/fopen a path, e.g. "a/b:/c", which does not exist
>> on the filesystem, Windows (correctly) fails to open it but sets
>> EINVAL to errno
>
> errno to EINVAL (as of now it sounds as if it is a EINVAL = errno,
> which makes no sense to me)
>
>> because the pathname has characters that cannot be
>> stored in its filesystem.
>>
>> As this is an expected failure, teach is_missing_file_error() helper
>> about this case.
>>
>> This is RFC,
>
> cc'd people knowledgeable of Windows.

This has been resolved I think with J6t/Dscho's patch yesterday.

Thanks.