From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 28 Jun 2017 04:08:23 GMT
Subject: Re: [PATCH] git-p4: parse marshal output "p4 -G" in p4 changes
Message-ID: <xmqqk23wycso.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170627191704.4446-1-miguel.torroja@gmail.com>

Miguel Torroja <miguel.torroja@gmail.com> writes:

> The option -G of p4 (python marshal output) gives more context about the
> data being output. That's useful when using the command "change -o" as
> we can distinguish between warning/error line and real change description.
>
> Some p4 triggers in the server side generate some warnings when
> executed. Unfortunately those messages are mixed with the output of
> "p4 change -o". Those extra warning lines are reported as {'code':'info'}
> in python marshal output (-G). The real change output is reported as
> {'code':'stat'}
>
> A new test has been created to t9807-git-p4-submit.sh adding a p4 trigger
> that outputs extra lines with "p4 change -o" and "p4 changes"
>
> Signed-off-by: Miguel Torroja <miguel.torroja@gmail.com>
> ---

It appears that https://travis-ci.org/git/git/builds/247724639
does not like this change.  For example:

    https://travis-ci.org/git/git/jobs/247724642#L1848

indicates that not just 9807 (new tests added by this patch) but
also 9800 starts to fail.

I'd wait for git-p4 experts to comment and help guiding this change
forward.

Thanks.