From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 02 Oct 2017 04:51:11 GMT
Subject: Re: [PATCH v5 6/6] ref-filter.c: parse trailers arguments with %(contents) atom
Message-ID: <xmqqk20ep2yo.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171002003304.77514-6-me@ttaylorr.com>

Taylor Blau <me@ttaylorr.com> writes:

> @@ -212,9 +212,10 @@ static void contents_atom_parser(const struct ref_format *format, struct used_at
>  		atom->u.contents.option = C_SIG;
>  	else if (!strcmp(arg, "subject"))
>  		atom->u.contents.option = C_SUB;
> -	else if (!strcmp(arg, "trailers"))
> -		atom->u.contents.option = C_TRAILERS;
> -	else if (skip_prefix(arg, "lines=", &arg)) {
> +	else if (skip_prefix(arg, "trailers", &arg)) {
> +		skip_prefix(arg, ":", &arg);
> +		trailers_atom_parser(atom, *arg ? NULL : arg);

A parameter for the call is missing.  I think you want 'format'
there.