From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 17 Sep 2018 16:32:51 GMT
Subject: Re: [PATCH v4 05/23] blame.c: rename "repo" argument to "r"
Message-ID: <xmqqk1nk84p8.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180915161759.8272-6-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> The current naming convention for 'struct repository *' is 'r' for
> temporary variables or arguments. I did not notice this. Since we're
> updating blame.c again in the next patch, let's fix this.

It is likely that we end up having to refer to an in-core repository
object in many places, so giving a short-and-sweet 'r' to it makes
quite a lot of sense.  One thing we may want to do as preparation
related to this effort is to sweep the codebase to make sure we do
not use 'r' as a variable that refers to anything other than an
in-core repository object.

Thanks.