From: Junio C Hamano Date: Wed, 07 Nov 2018 01:32:10 GMT Subject: Re: [PATCH 1/1] Windows: force-recompile git.res for differing architectures Message-ID: In-Reply-To: Johannes Sixt writes: > Am 06.11.18 um 15:55 schrieb Johannes Schindelin via GitGitGadget: >> From: Johannes Schindelin >> >> When git.rc is compiled into git.res, the result is actually dependent >> on the architecture. That is, you cannot simply link a 32-bit git.res >> into a 64-bit git.exe. >> >> Therefore, to allow 32-bit and 64-bit builds in the same directory, we >> let git.res depend on GIT-PREFIX so that it gets recompiled when >> compiling for a different architecture (this works because the exec path >> changes based on the architecture: /mingw32/libexec/git-core for 32-bit >> and /mingw64/libexec/git-core for 64-bit). > > On Linux, when I recompile for a different architecture, CFLAGS would > change, so I would have thought that GIT-CFLAGS were the natural > choice for a dependency. Don't they change in this case on Windows, > too? Depending on GIT-CFLAGS would have a better chance of being safe, I guess, even though it can at times be overly safe, than GIT-PREFIX, I suspect. As a single user target in Makefile, which is only used by Dscho, who intends to stick to /mingw(32|64)/ convention til the end of time, I think the posted patch is OK, though.