From: Junio C Hamano Date: Wed, 12 Feb 2020 22:40:37 GMT Subject: Re: SHA1dc on mac Message-ID: In-Reply-To: <20200212223122.svthiwmh3js7i47b@glandium.org> Mike Hommey writes: > On Wed, Feb 12, 2020 at 11:46:31AM -0500, Eric Sunshine wrote: >> On Wed, Feb 12, 2020 at 3:57 AM Mike Hommey wrote: >> > If I'm not mistaken in my reading of the various files involved, it >> > looks like for some reason, building git on mac leads to using Apple >> > Common Crypto for SHA1, rather than SHA1dc, which seems unfortunate. >> > Is that really expected? >> >> There was a discussion on this topic a while back[1], and it does seem >> that the behavior you describe is intentional[2]. > > That discussion predates SHA1dc, though. Yes, but the essense is the same. It was phrased as "is there a good reason to prefer CommonCrypto over block-sha1?" but it really was "is there a good reason to prefer CommonCrypto over the best we offer?" And the best we offer, which used to be block-sha1, is now sha1dc.