From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 14 Aug 2020 20:43:08 GMT
Subject: Re: [PATCH 3/5] protocol-capabilities.txt: clarify "allow-x-sha1-in-want" re SHA-256
Message-ID: <xmqqk0y1uffn.fsf@gitster.c.googlers.com>
In-Reply-To: <CAN0heSpv5L67hYSX44LkwQ1pJ+_px_W=FQ4piXKS1anpMi0n2w@mail.gmail.com>

Martin Ågren <martin.agren@gmail.com> writes:

>> I think we should have either a new sha256 capability or a more
>> generic hash-algo capability whose value can be set to sha256.
>> Neither the connection initiators or the acceptors should talk
>> in sha256 until both ends agreed to do so.
>
> I think we should, and I think we do. I haven't dug into the details,
> but "object-format" looks like it's just that.

Ah, Yes, my thinko.

> Maybe instead of SHA-1 and SHA-256, this should talk about "whatever has
> been negotiated through 'object-format', or SHA-1", similar to brian's
> suggestion elsewhere.

Yup, that would be wonderful.

Thanks.