From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 10 Feb 2021 07:24:53 GMT
Subject: Re: [PATCH v2 4/9] t3905: remove nested git in command substitution
Message-ID: <xmqqk0rg4c6y.fsf@gitster.c.googlers.com>
In-Reply-To: <57c21e2461eea8a37456d211f38fb668278cb2ed.1612855690.git.liu.denton@gmail.com>

Denton Liu <liu.denton@gmail.com> writes:

> If a git command in a nested command substitution fails, it will be
> silently ignored since only the return code of the outer command
> substitutions is reported. Factor out nested command substitutions so
> that the error codes of those commands are reported.

Locally this makes sense.  We may want to clean it up further by
using existing blob objects, instead of using hash-objects, but that
is for some other day.