From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 27 Sep 2021 21:54:41 GMT
Subject: Re: [PATCH v2 3/5] *.h _INIT macros: don't specify fields equal to 0
Message-ID: <xmqqk0j1ofa6.fsf@gitster.g>
In-Reply-To: <patch-v2-3.5-590220bbdcc-20210927T124407Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> -#define IPC_CLIENT_CONNECT_OPTIONS_INIT { \
> -	.wait_if_busy = 0, \
> -	.wait_if_not_found = 0, \
> -	.uds_disallow_chdir = 0, \
> -}
> +#define IPC_CLIENT_CONNECT_OPTIONS_INIT { 0 }

The original explicitly initializes the members using designated
init, and the loss somewhat feels like a temporary regression, but
as long as the new norm is

 - If there is *no* member that is initialized to non-zero value, we
   use { 0 }, and

 - Otherwise, we only explicitly initialize members to non-zero
   value using designated initializers

this conversion is perfectly fine.