From: Junio C Hamano Date: Thu, 31 Mar 2022 20:37:56 GMT Subject: Re: [PATCH v2] worktree: add -z option for list subcommand Message-ID: In-Reply-To: "Phillip Wood via GitGitGadget" writes: > From: Phillip Wood > > Add a -z option to be used in conjunction with --porcelain that gives > NUL-terminated output. As 'worktree list --porcelain' does not quote > worktree paths this enables it to handle worktree paths that contain > newlines. > > Signed-off-by: Phillip Wood > --- > worktree: add -z option for list subcommand > > Thanks to Eric, Jean-Noël and Junio for their comments on V1. I've > reworded the docs and option help and tweaked the tests as suggested by > Eric, fixed the error messages as suggested by Eric/Jean-Noël and > changed the implementation to use write_name_quoted() as suggested by > Junio. I've punted doing anything about quoting the output without -z > for now, I'll fix that with and without --porcelain in another series. Thanks for an update. Will queue. I think this iteration is good to merge to 'next', but let's wait for a few days to see what others think. It also made me wonder if "-z" alone should be made to imply "--porcelain" (in other words, is there a good reason to ask for NUL-terminated output when you are producing a human-readable output?), but we can start stricter like this patch does; we can later loosen it if needed.