From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 21 Oct 2022 17:37:03 GMT
Subject: Re: [PATCH v4 3/8] rebase --merge: fix reflog when continuing
Message-ID: <xmqqk04tm62o.fsf@gitster.g>
In-Reply-To: <2c965f4b97c1773abc6b844b87fa64c5d6d1524c.1666344108.git.gitgitgadget@gmail.com>

"Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:

> ... This
> introduces a memory leak similar to the one leaking GIT_REFLOG_ACTION
> in pick_commits().

Is it just the matter of freeing previous_reflog_action after you
call setenv(), or does it take much more involved changes?

> Both of these will be fixed in a future series that
> stops the sequencer calling setenv().

If it gets fixed in a future step in the same series, that is a
different matter, but if it is easy enough not to deliberately
introduce a new leak, we'd prefer to do so.