From: Junio C Hamano Date: Tue, 07 Feb 2023 18:53:10 GMT Subject: Re: [GSoC][PATCH] commit: warn the usage of reverse_commit_list() helper Message-ID: In-Reply-To: <20230207150359.177641-1-five231003@gmail.com> Kousik Sanagavarapu writes: > -/* Modify list in-place to reverse it, returning new head; list will be tail */ > +/* > + * Modify list in-place to reverse it, returning new head; list will be tail. > + * > + * NOTE! The reversed list is constructed using the elements of the original > + * list, hence losing the original list. > + */ After re-reading the original, I realize that "in-place" is good enough clue to say that this is destructive.