From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 11 Sep 2023 06:28:01 GMT
Subject: Re: [PATCH 26/32] object-file-convert: Implement convert_object_file_{begin,step,end}
Message-ID: <xmqqjzsxi5qm.fsf@gitster.g>
In-Reply-To: <20230908231049.2035003-26-ebiederm@xmission.com>

"Eric W. Biederman" <ebiederm@xmission.com> writes:

> +	const struct git_hash_algo *from = state->from;
> +	const struct git_hash_algo *to = state->to;
> +	struct strbuf *out = state->outbuf;
> +	const char *buffer = state->buf;
> +	size_t payload_size, size = state->buf_len;;

The excess ';' at the end is an empty statment, hence ...

> +	struct object_id oid;
>  	const char *p;
> +	int ret = 0;

... these three violate our "no declaration after statement" house rule.