From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 10 Sep 2024 14:44:10 GMT
Subject: Re: [PATCH v3 4/6] config: add git_configset_alloc() and git_configset_clear_and_free()
Message-ID: <xmqqjzfjo9fp.fsf@gitster.g>
In-Reply-To: <c8d65466-a9c3-4556-84c1-3daf0c7cea14@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

> On 10/09/2024 07:41, Patrick Steinhardt wrote:
>> Is there ever a case where one wants to
>> allocate the configset, but not use it?
>
> That was my thought too - I suggested providing git_configset_new()
> that would allocate and initialize a config set in my response to the
> last round [1]. It is good to see that the struct in now namespaced in
> the next patch but separating out allocation and initialization makes
> the api harder to use than it needs to be. I'd also like to see
> git_configset_clear_and_free() become git_configset_free().

Makes sense.