From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 11 Mar 2026 18:13:37 GMT
Subject: Re: [PATCH v3 2/2] list-objects-filter-options: avoid strbuf_split_str()
Message-ID: <xmqqjyvip73i.fsf@gitster.g>
In-Reply-To: <20260311174816.GB1900488@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Wed, Mar 11, 2026 at 05:33:36PM +0000, Deveshi Dwivedi wrote:
>
>> +	while (*p && !result) {
>> +		const char *end = strchrnul(p, '+');
>> +
>> +		strbuf_reset(&sub);
>> +		strbuf_add(&sub, p, end - p);
>> +
>> +		if (sub.len)
>> +			result = parse_combine_subfilter(filter_options, sub.buf, errbuf);
>> +
>> +		if (!*end)
>> +			break;
>> +		p = end + 1;
>>  	}
>> +	strbuf_release(&sub);
>
> This version of the loop looks good to me.
>
> -Peff

Thanks, both.  Will queue.