From: Junio C Hamano Date: Sun, 21 Jun 2026 20:16:12 GMT Subject: Re: [PATCH v3 0/2] environment: move ignore_case into repo_config_values Message-ID: In-Reply-To: <20260619155152.642760-1-cat@malon.dev> Tian Yuchen writes: > This series continues the ongoing libification effort by moving > this global variable into 'struct repo_config_values', tying it > to the specific repository instance it was read from. This allows > us to encapsulate the configuration without altering its > eager-parsing behavior. Looks good. > compat/win32/path-utils.c --- Is it appropriate to include the > repository.h header file? As the compat/ layer is not meant as a general purpose POSIX emulation wrapper that is generally reusable to projects other than us, if we have a knob settable by end users to affect behaviours of lower layer in compat/, it is natural to make repo-settings available to them. What is the perceived problem you have in mind, and what are your proposed alternatives?